Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-1330) Change order of revokation. #569

Merged
merged 1 commit into from Sep 16, 2014

Conversation

fnerdwq
Copy link
Contributor

@fnerdwq fnerdwq commented Sep 16, 2014

Fixes Jira Issue MODULES-1330.

# revoke grant option needs to be a extra query, because
# "REVOKE ALL PRIVILEGES, GRANT OPTION [..]" is only valid mysql syntax
# if no ON clause is used.
# It hast to be executed befor "REVOKE ALL [..]" since a GRANT has to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/befor/before/

@igalic
Copy link
Contributor

igalic commented Sep 16, 2014

looks fine otherwise, even though it's still super confusing.

@fnerdwq
Copy link
Contributor Author

fnerdwq commented Sep 16, 2014

Fixed the typo.
I totally agree. It doesn't look like the cleanest way to update the GRANTS. At least in this order it's working ;-)

igalic added a commit that referenced this pull request Sep 16, 2014
(MODULES-1330) Change order of revokation.
@igalic igalic merged commit 443ff06 into puppetlabs:master Sep 16, 2014
@igalic
Copy link
Contributor

igalic commented Sep 16, 2014

fair enough. thank you!

@fnerdwq fnerdwq deleted the mysql_grant_revokation branch September 24, 2014 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants