Fix escaped backslashes in grants #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mysql uses the underscore character to represent a single character wildcard. * A grant on table `the_database`.* would match `theAdatabase`.*, so underscores must be escaped to avoid this match. * The output from mysql escapes special characters (\n, \t, \0, and \\), but the input does not need to be escaped. * In order for the provider to compare the tables, the output of mysql -NBe <query> must have \\ substituted with \.
|
and I presume it's not enough to quote? |
|
Unfortunately no, if you quote it, a _ is still a wildcard. You can also pass --raw/-r to the shell command, but that will also cause \n, \t, and \0 to not be escaped. I highly doubt there will be NUL or tabs in grant tables, but that seems downright dangerous. |
igalic
added a commit
that referenced
this pull request
Nov 7, 2014
Fix escaped backslashes in grants
|
okay, thanks for the explanation and the patch @skroll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wildcard.
the_database.* would matchtheAdatabase.*, sounderscores must be escaped to avoid this match.
but the input does not need to be escaped.
mysql -NBe must have \ substituted with .