Fix regression in username validation #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cdd7132 added logic to catch invalid database usernames, but the regex it uses fails to match usernames with special characters that are properly quoted, causing errors with usernames that used to work in versions < 3.0.0. This fixes the regex so that if the username is quoted, anything is allowed between the quotes. From the docs (http://dev.mysql.com/doc/refman/5.5/en/identifiers.html): "Permitted characters in quoted identifiers include the full Unicode Basic Multilingual Plane (BMP), except U+0000"
|
ooh.. nice. thanks for the catch. |
igalic
added a commit
that referenced
this pull request
Nov 14, 2014
Fix regression in username validation
|
(i've merging this despite a travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit cdd7132 added logic to catch invalid database usernames,
but the regex it uses fails to match usernames with special characters that are properly quoted,
causing errors with usernames that used to work in versions < 3.0.0. This fixes the regex so that
if the username is quoted, anything is allowed between the quotes.
From the docs (http://dev.mysql.com/doc/refman/5.5/en/identifiers.html):
"Permitted characters in quoted identifiers include the full Unicode Basic Multilingual Plane (BMP),
except U+0000"