-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-1143) Add package_manage parameters #617
(MODULES-1143) Add package_manage parameters #617
Conversation
9b710a5
to
ce73747
Compare
ce73747
to
4cb3568
Compare
|
i'm really having trouble comprehending the motivation behind this ticket/pr. ping @hunner bc you approved of the ticket ;) |
|
I don't have any strong feelings on this PR either way. However, I can guess that at least one of the motivations for the person who raised the ticket would have been the MySQL forks that are floating around (and will probably increase given public statements from Oracle). Percona has its own module on the Forge already, although one could argue that it differs from MySQL enough to need one. |
|
I would like to argue that the module is tagged with percona on the forge but is not able to work with it at this time. With this PR integrated one would be able to install percona (or MariaDB) and have it managed by this module. It would make it possible to get an existing server under Puppet control more easily which is a big plus in my eyes. |
|
@Micsi it's possible, even now, to install and manage (mostly…) MariaDB. @juniorsysadmin would you mind rebasing this pull request? |
4cb3568
to
92a598d
Compare
|
@igalic unfortunately, it's not really choosable... the module uses MariaDB on some versions of some distros (as to params.pp). The user is not involved. Again, I would see this a big plus for several reasons:
To the last point: I have my systems upgrade automatically using puppetlabs-apt unattended-upgrades. Some important pieces are hold, notably the databases as upgrades of those involve a server restart |
92a598d
to
5ef331f
Compare
… to start service - to ensure it gets started with correct settings and does not try to enable service before it actually exists :)
… module or in unusual places and make it play nicely with user specified package_names. Works with PR puppetlabs#617
5ef331f
to
c663511
Compare
c17a96c
to
24da192
Compare
5f099d5
to
51e2cd7
Compare
51e2cd7
to
0d213f9
Compare
This patch adds a package_manage parameter for both mysql::server and mysql::client
0d213f9
to
f5a693b
Compare
(MODULES-1143) Add package_manage parameters
|
Thanks @juniorsysadmin ! |
This patch adds a package_manage parameter for both mysql::server and mysql::client