Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance. #655

Merged
merged 1 commit into from Feb 6, 2015
Merged

(MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance. #655

merged 1 commit into from Feb 6, 2015

Conversation

rnelson0
Copy link
Contributor

No description provided.

@hunner
Copy link
Contributor

hunner commented Feb 2, 2015

Odd, that should work as the provider is actually called mysql. Though since there is only one provider, it's not required. https://github.com/puppetlabs/puppetlabs-mysql/blob/master/lib/puppet/provider/mysql_user/mysql.rb#L2

@rnelson0
Copy link
Contributor Author

rnelson0 commented Feb 2, 2015

That's what I thought, but I could not determine why the provider fails every time.

hunner added a commit that referenced this pull request Feb 6, 2015
(MODULES-1731) Invalid parameter 'provider' removed from mysql_user instance.
@hunner hunner merged commit b57191f into puppetlabs:master Feb 6, 2015
@optiz0r
Copy link

optiz0r commented Mar 5, 2015

This issue has been reintroduced during the refactor for 3.3.0

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter provider on Mysql_user[backups@localhost] at /home/puppet/environments/dev/thirdparty/mysql/manifests/backup/mysqldump.pp:26 on node sql1.local     
Warning: Not using cache on failed catalog

@igalic
Copy link
Contributor

igalic commented Mar 5, 2015

i'm confused. is this failing on master for you?

this seems to be failing for different reasons…

@optiz0r
Copy link

optiz0r commented Mar 5, 2015

Hi @igalic,

In 3.1 mysql::server::backup explicitly set the provider parameter on mysql_user["${backupuser}@localhost"]. That didn't work and prompted this PR in which the offending line was removed. Between 3.2 and 3.3 the mysql::server::backup class was refactored into mysql::backup::mysqldump which re-added the previously removed provider. I'm now experiencing the same error message that this PR originally solved from the new location (as shown in my previous comment).

Comparing the 3.3.0 tree with master I suspect master would still be affected. This looks like a regression.

I've commented on this thread because it had the right context, but perhaps opening a new issue against 3.3.0 would be more appropriate?

@igalic
Copy link
Contributor

igalic commented Mar 5, 2015

@optiz0r please see #687.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants