Only set up ordering between the config file and the service if we're managing the config file.

[timmooney]

With latest (3.2.0), if you try use manage_config_file => false, you get an undefined resource for File['mysql-config-file'].

This is because mysql::server::config is conditionally defining that resource, but mysql::server::service is always requiring it.

A different approach to fixing this issue, which arguably has a bit more flexibility for the module end user, would be to leave the code in mysql::server::service as-is, and instead change mysql::server::config so that it always defines a File resource for mysql-config-file, but if manage_config_file is false, it doesn't set any attributes for the File. That allows people to use manage_config_file => false and potentially manage their config some other way, but still have the right ordering for the file and the service resources.

[igalic]

i like this change.

[mcanevet]

@igalic @mhaskel @cmurphy don't you think this worth a 3.3.1 release?

[igalic]

@mcanevet do you wanna do a pull request for 3.3.1?

[underscorgan]

@igalic @mcanevet if we need a release with this bug fix we will handle all the release prep, no need to submit a pull request for that. We'll look into doing a bugfix for this, though we may just release 3.4.0 as a few features have been added also.