Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added server_id fact #676

Merged
merged 2 commits into from
Mar 4, 2015
Merged

Added server_id fact #676

merged 2 commits into from
Mar 4, 2015

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Feb 24, 2015

use mac address for "guaranteed" uniqueness ;)

@igalic
Copy link
Contributor Author

igalic commented Feb 24, 2015

rebased, squashed and white-space clean version of #595.
tested (in production, obvs)

now the only thing left are rspec tests;)

@igalic
Copy link
Contributor Author

igalic commented Feb 24, 2015

@NoodlesNZ @dveeden comments?

@NoodlesNZ
Copy link
Contributor

I'll write some rspec tests tomorrow for this if you want to hold off the merge.

@igalic
Copy link
Contributor Author

igalic commented Feb 24, 2015

+1

@igalic
Copy link
Contributor Author

igalic commented Feb 24, 2015

i'm in no hurry to merge it myself, as i've already merged it to my own mariadb branch ;)

@underscorgan
Copy link
Contributor

@igalic this also needs docs in the README, the Facts section just doesn't exist yet since this is the first fact

@underscorgan
Copy link
Contributor

Closes #595

@igalic
Copy link
Contributor Author

igalic commented Mar 2, 2015

aaaah. thanks. will add a doc!

@igalic
Copy link
Contributor Author

igalic commented Mar 2, 2015

done @mhaskel!

@igalic
Copy link
Contributor Author

igalic commented Mar 2, 2015

oh… tests… _

@igalic
Copy link
Contributor Author

igalic commented Mar 2, 2015

tests and documentation. i'm on a roll today

@tphoney
Copy link
Contributor

tphoney commented Mar 2, 2015

Really close :), i think it is a formatting issue.

@igalic
Copy link
Contributor Author

igalic commented Mar 2, 2015

missing an it block. because that makes perfect sense, rspec >_>

NoodlesNZ and others added 2 commits March 4, 2015 08:56
@NoodlesNZ @igalic
Added server_id fact
dbf54ce 
use mac address for "guaranteed" uniqueness ;)
@igalic
document mysql_server_id fact and add spec tests
d7077b4 
add spec tests, expand documentation to mention lo behaviour
also, rename fact, for, consistency.
@igalic
Copy link
Contributor Author

igalic commented Mar 4, 2015

@mhaskel rebased and squashed, tests are still failing and i have absolutely no idea why.

@tphoney
Copy link
Contributor

tphoney commented Mar 4, 2015

@mhaskel @igalic I may have committed some git shenanigans. But i found your problems, a couple of typo's macadddress should be macaddress. And fixing the comparison for lo. #686 is where i fixed it

@underscorgan underscorgan merged commit d7077b4 into puppetlabs:master Mar 4, 2015
@igalic igalic deleted the server_id branch March 5, 2015 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igalic @NoodlesNZ @underscorgan @tphoney @LukasAud