Bugfix on Xtrabackup crons #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cron { 'xtrabackup-weekly': | ||
| ensure => $ensure, | ||
| command => 'innobackupex $backupdir', | ||
| command => "innobackupex $backupdir", |
There was a problem hiding this comment.
this needs {} around the variable:
command => "innobackupex ${backupdir}",
|
general comments, you might wanna use the github flow workflow for your (next) patch |
| @@ -47,12 +43,11 @@ | |||
| require => Package['percona-xtrabackup'], | |||
| } | |||
|
|
|||
| file { 'mysqlbackupdir': | |||
| file { $backupdir: | |||
There was a problem hiding this comment.
nope, this is a bit over-enthusiastic.
we need this for our dependencies, and our spec tests.
|
Sorry about that, I surely will use more the branches for my next PR. |
mvisonneau
force-pushed
the
master
branch
2 times, most recently
from
28e4b78
to
2b9e777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a simple modification in order to correctly retrieve the value of $backupdir into the crontab definition.