Escape $root_password during execs. #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With single quotes, I believe puppet will then treat ${root_password} as a literal string? |
|
No need to escape the single quotes. Puppet is smarter than bash. |
|
Please update the spec tests for your change. Currently they expect un-escaped passwords and will fail when run on your branch. |
|
Spec tests updated. |
|
@razorsedge a general overcommitment from both of us, combined with a lack of automated integration tests :) |
|
Sorry this got lost in the shuffle! Unfortunately, it no longer merges cleanly. If you could squash your commits and rebase this I see no reason we can't merge it at that point. |
Some characters used in a password can cause the shell in an exec to do unexpected things unless the password is enclosed in single quotes. Updated the rspec tests to deal with the password quoting.
|
I finally found the time to work on this. And I think I managed to figure out rebasing. |
bodepd
added a commit
that referenced
this pull request
Aug 9, 2012
Escape $root_password during execs.
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
(FM-7720/FM-7722/FM-7723) Consolidate Windows Metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some characters used in a password can cause the shell in an exec to do
unexpected things unless the password is enclosed in single quotes.
Try putting ';' in the middle of your password to test how interestingly it fails.