Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the module to the new layout for easier testing and packaging #77

Merged
merged 2 commits into from May 25, 2012

Conversation

branan
Copy link
Contributor

@branan branan commented May 24, 2012

  • Add spec_full, spec_prep, and spec_clean targets
  • Rename Gemfile -> .gemfile for less cluttered module packages
  • Append fixtuers to modulepath instead of overwriting
  • Use a more complete .gitignore
  • Remove the recursive symlink

* Add spec_full, spec_prep, and spec_clean targets
* Rename Gemfile -> .gemfile for less cluttered module packages
* Append fixtuers to modulepath instead of overwriting
* Use a more complete .gitignore
* Remove the recursive symlink
@branan
Copy link
Contributor Author

branan commented May 24, 2012

I actually hadn't noticed that mysql had build/clean tasks already. I'll add those to my updated Rakefile and re-open this PR when it's ready.

@branan branan closed this May 24, 2012
@branan
Copy link
Contributor Author

branan commented May 25, 2012

So much for that idea. A quick test shows that rake build as it was implemented is rather fragile. This appears to be a git bug (git-describe does not always return the most recent tag), but since I can't re-implement build as it was without working around that somehow, I'm just going to use my current Rakefile.

@branan branan reopened this May 25, 2012
bodepd added a commit that referenced this pull request May 25, 2012
Update the module to the new layout for easier testing and packaging
@bodepd bodepd merged commit ece11c5 into puppetlabs:master May 25, 2012
pmcmaw pushed a commit to pmcmaw/puppetlabs-mysql that referenced this pull request Mar 3, 2021
Revert "(FM-7720/FM-7722/FM-7723) Consolidate Windows Metadata"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants