Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add the ability to set a empty string as option parameter #791

Merged
merged 1 commit into from Jan 11, 2016

Conversation

roidelapluie
Copy link
Contributor

Prior to 136b1aa it was possible to
have an empty string as value of a my.cnf parameter, resulting in a line
with just the parameter name.

That commit re-enable that behavior that was removed by accident.

@roidelapluie roidelapluie force-pushed the empty-string-as-parameter branch 2 times, most recently from 785038c to c0a9ada Compare January 8, 2016 13:00
Prior to 136b1aa it was possible to
have an empty string as value of a my.cnf parameter, resulting in a line
with just the parameter name.

That commit re-enable that behavior that was removed by accident.
@igalic
Copy link
Contributor

igalic commented Jan 11, 2016

duh… i think it was discussed separately, but never really fixed :(
thank you very much for catching and fixing this, @roidelapluie!

igalic added a commit that referenced this pull request Jan 11, 2016
Re-Add the ability to set a empty string as option parameter
@igalic igalic merged commit 0b3e310 into puppetlabs:master Jan 11, 2016
@baurmatt
Copy link
Contributor

This change just broke a couple of our MySQL installations. We definitely need a feature to remove values we do not need from the $default_options hash. Setting the option to 'undef' doesn't work for us as we're using Hiera.

@hunner
Copy link
Contributor

hunner commented Oct 17, 2016

@baurmatt What about using ~ as the value in hiera, assuming you're using yaml? Or whatever the nil/null value is for the backend you're using. re https://groups.google.com/forum/#!topic/puppet-users/0l3m4VCHjOg

@baurmatt
Copy link
Contributor

@hunner Woah, honestly i thought no one would care about a comment in an old issue, but you did and suggested a solution which doesn't need any modification at all. Thank you very much, works great! :)

@hunner
Copy link
Contributor

hunner commented Oct 17, 2016

I get emailed for comments and usually keep an eye out for PRs that broke something unexpected. Thanks for reporting it!

@roidelapluie
Copy link
Contributor Author

Thanks guys. Sorry it broke your setup, be aware that it broke mine first :) Nice @hunner the ~ tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants