add new backup dump parameter maxallowedpacket #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfasnacht thanks for the PR ! there is so many good things here, docs / acceptance tests / clean code. Unfortunately your change has broken the unit tests, as seen in the TravisCI failure. Could you please have a look, and squash your commits. |
|
Thanks, I will do that, the check was still running the last time I checked. |
|
@tphoney The checks pass now. |
|
@cfasnacht great work, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maxallowedpacket parameter for the puppetlab mysql module backup dump script. Feature request: https://tickets.puppetlabs.com/browse/PUP-6404 The default value is 1MB as it is default for Mysql.