MODULES-3711 - Add limit to mysql server ID generated value

[QuentinMoss]

MySQL server ID requires a value that is less than 2^32. With the current server-id generation it's possible to get a value that exceeds this limit. Reference the following documentation:
– https://dev.mysql.com/doc/refman/5.7/en/replication-options.html#option_mysqld_server-id
I have provided an example of the fix below:

irb(main):002:0> x = ['ff','ff','ff','ff','ff','ff'][2..-1].inject(0)
{ |total, value| (total << 6) + value.hex }
=> 67907775

irb(main):003:0> x < 2**32
=> true

See bug report here: https://tickets.puppetlabs.com/browse/MODULES-3711

[trevor-vaughan]

👍 However, should there be an additional test that explicitly checks to make sure that the integer is < 2**32?

[rnelson0]

@trevor-vaughan I think that's mathematically impossible in the current state of our universe, though :)

[trevor-vaughan]

@rnelson0 So, you're saying that failure of that test would be a very bad thing?

[rnelson0]

Yep, but you're testing math, not the puppet code, at that point.

Rob Nelson
rnelson0@gmail.com

[bmjen]

Thanks for the patch @QuentinMoss ! As well as the feedback @trevor-vaughan and @rnelson0 . I agree with Rob here.

Thanks!