new config define and a small bugfix #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
savar
commented
Aug 13, 2012
savar
commented
- added a define to easily create .cnf files in /etc/mysql/conf.d/
- fix wrong path for .my.cnf in /etc/
* added a define to easily create .cnf files in /etc/mysql/conf.d/ * fix wrong path for .my.cnf in /etc/
| @@ -99,7 +99,7 @@ | |||
| } | |||
|
|
|||
| if $etc_root_password { | |||
| file{ '/etc/my.cnf': | |||
| file{ '/etc/.my.cnf': | |||
There was a problem hiding this comment.
I'm not familiar with /etc/.my.cnf. Are you thinking of ~/.my.cnf?
|
I'm neither familiar with this /etc/.my.cnf. But I only make it like the docu says itself but you're right.. maybe the doc should be switched to /etc/my.cnf instead the other way around. It's definitly not ~/.my.cnf because this is handled in line 96+ and the 'man mysql' shows this: So i will change this. |
* rollback for the file location + updated the documentation
|
I'm quite happy with this. It would be really awesome for you to add an rspec test for the new defined type. Let me know if you're going to do that. This can definitely get merged either way. |
* fixed a typo in the documentation * added documentation for parameter +notify_service+ * added rspec test
|
Here you're :).. thanks for comment.. i fixed also the documentation a little bit. I hope the rspec test is ok? |
hunner
added a commit
that referenced
this pull request
Aug 29, 2012
new config define and a small bugfix
This was referenced Sep 28, 2012
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
Prep-release v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.