Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-node_encrypt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.7
Choose a base ref
...
head repository: puppetlabs/puppetlabs-node_encrypt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 13 commits
  • 12 files changed
  • 3 contributors

Commits on Sep 27, 2017

  1. Use pseudo-relative include paths in parser-function and type.

    This fixes #8 and #14 in our setup (Puppet 5.2.0).
    olifre committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    8921548 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2017

  1. node_encrypt.rb: Use dummy 4 byte password to read key.

    Since Ruby 2.4, it is required to pass a 4 byte password,
    even if the key has no password at all, otherwise it fatals out.
    This leads to ugly workarounds such as these:
    https://github.com/github/octocatalog-diff/blob/6093d3c24b0be8045d779b1f6cf2e56367e2e8fb/lib/octocatalog-diff/util/httparty.rb#L127
    Since we know these keys always have no password, we can just use 1234.
    olifre committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    d6077ac View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Update node_encrypt.rb

    binford2k authored Oct 26, 2017
    Configuration menu
    Copy the full SHA
    d185b73 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #20 from unibonn/ruby-2.4-compatibility

    node_encrypt.rb: Use dummy 4 byte password to read key.
    binford2k authored Oct 26, 2017
    Configuration menu
    Copy the full SHA
    f3c8f27 View commit details
    Browse the repository at this point in the history
  3. use require_relative

    binford2k authored Oct 26, 2017
    Configuration menu
    Copy the full SHA
    3f39d56 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9dec03f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #19 from unibonn/use-pseudo-relative-ruby-file-paths

    Use pseudo-relative include paths in parser-function and type.
    binford2k authored Oct 26, 2017
    Configuration menu
    Copy the full SHA
    8911334 View commit details
    Browse the repository at this point in the history
  6. Add Puppet 5 support to the certificates class

    This will do its best to manage the certificate access on Puppet 5.
    Unfortunately, it's not reasonably possible to do if the machine is
    using legacy auth.conf, and there's not a good way to tell whether that
    is the case on OSS. Therefore, we fail out and require the user to
    either indicate that they're using HOCON, or to not manage the
    whitelist. We fail by default because requiring a minor change in
    classification is better than a false sense of security.
    
    Tangent: since they're public certificates, I'm not even convinced that
    it's worth trying to protect them. Perhaps it's time to just drop the
    whitelist idea completely?
    
    Fixes #18
    binford2k committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    23a81ba View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2017

  1. Configuration menu
    Copy the full SHA
    f925c55 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #23 from binford2k/puppet5

    Add Puppet 5 support to the certificates class
    binford2k authored Oct 27, 2017
    Configuration menu
    Copy the full SHA
    a9d1508 View commit details
    Browse the repository at this point in the history
  3. Add comparison to Sensitive

    Fixes #11
    binford2k committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    33149b6 View commit details
    Browse the repository at this point in the history
  4. Added alternative ways to pass data when encrypting on the CLI

    * Prompt for a value by using --prompt
    * Read from piped stdin
    
    Fixes #10
    binford2k committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    ad8bda8 View commit details
    Browse the repository at this point in the history
  5. releasing v0.3.0

    binford2k committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    3b42faa View commit details
    Browse the repository at this point in the history
Loading