-
Notifications
You must be signed in to change notification settings - Fork 22
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-node_encrypt
base: v0.2.7
head repository: puppetlabs/puppetlabs-node_encrypt
compare: v0.3.0
- 13 commits
- 12 files changed
- 3 contributors
Commits on Sep 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8921548 - Browse repository at this point
Copy the full SHA 8921548View commit details
Commits on Oct 25, 2017
-
node_encrypt.rb: Use dummy 4 byte password to read key.
Since Ruby 2.4, it is required to pass a 4 byte password, even if the key has no password at all, otherwise it fatals out. This leads to ugly workarounds such as these: https://github.com/github/octocatalog-diff/blob/6093d3c24b0be8045d779b1f6cf2e56367e2e8fb/lib/octocatalog-diff/util/httparty.rb#L127 Since we know these keys always have no password, we can just use 1234.
Configuration menu - View commit details
-
Copy full SHA for d6077ac - Browse repository at this point
Copy the full SHA d6077acView commit details
Commits on Oct 26, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d185b73 - Browse repository at this point
Copy the full SHA d185b73View commit details -
Merge pull request #20 from unibonn/ruby-2.4-compatibility
node_encrypt.rb: Use dummy 4 byte password to read key.
Configuration menu - View commit details
-
Copy full SHA for f3c8f27 - Browse repository at this point
Copy the full SHA f3c8f27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f39d56 - Browse repository at this point
Copy the full SHA 3f39d56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dec03f - Browse repository at this point
Copy the full SHA 9dec03fView commit details -
Merge pull request #19 from unibonn/use-pseudo-relative-ruby-file-paths
Use pseudo-relative include paths in parser-function and type.
Configuration menu - View commit details
-
Copy full SHA for 8911334 - Browse repository at this point
Copy the full SHA 8911334View commit details -
Add Puppet 5 support to the certificates class
This will do its best to manage the certificate access on Puppet 5. Unfortunately, it's not reasonably possible to do if the machine is using legacy auth.conf, and there's not a good way to tell whether that is the case on OSS. Therefore, we fail out and require the user to either indicate that they're using HOCON, or to not manage the whitelist. We fail by default because requiring a minor change in classification is better than a false sense of security. Tangent: since they're public certificates, I'm not even convinced that it's worth trying to protect them. Perhaps it's time to just drop the whitelist idea completely? Fixes #18
Configuration menu - View commit details
-
Copy full SHA for 23a81ba - Browse repository at this point
Copy the full SHA 23a81baView commit details
Commits on Oct 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f925c55 - Browse repository at this point
Copy the full SHA f925c55View commit details -
Merge pull request #23 from binford2k/puppet5
Add Puppet 5 support to the certificates class
Configuration menu - View commit details
-
Copy full SHA for a9d1508 - Browse repository at this point
Copy the full SHA a9d1508View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33149b6 - Browse repository at this point
Copy the full SHA 33149b6View commit details -
Added alternative ways to pass data when encrypting on the CLI
* Prompt for a value by using --prompt * Read from piped stdin Fixes #10
Configuration menu - View commit details
-
Copy full SHA for ad8bda8 - Browse repository at this point
Copy the full SHA ad8bda8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b42faa - Browse repository at this point
Copy the full SHA 3b42faaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.2.7...v0.3.0