Allow redact to take defines as well as classes

[ross-w]

Hi there

Forgive me; I'm a complete newbie at this level of Puppet internals. Is there any reason the redact function can't be modified in this way to work with defines as well as classes?

It /appears/ to work for our use case, but I can't be sure I'm not missing something really obvious or breaking something rather important. Comments and/or rejection welcome.

[ross-w]

Hi @binford2k tell me to go away if you think I'm being a nag. I would be interested to know what you think of this, if there's something else I've not thought of or missed, etc.

[binford2k]

@ross-w or @sammcj what validation steps did you take? As long as you've tested on classes & defines both, I'll totally do some more stringent testing and merge this.

[ross-w]

@binford2k tested on one define, two defines, one class. That said I could have missed something obvious that makes the whole thing pointless or breaks something else important that I haven't noticed. But from my testing it /seems/ to work...

[binford2k]

Added some tests and merged, c6a67cf

[sammcj]

Thanks for that @binford2k, do you mind tagging the release so we can add the requirement to https://github.com/sammcj/puppet-luks ? Thanks,

[binford2k]

@sammcj if it's a priority, I'd be happy to make a minor release. There are a couple more updates I wanted to make, but they can wait.

[sammcj]

No problems, the tag can wait :)