node_encrypt.rb: Use dummy 4 byte password to read key. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That... seems monumentally stupid. Can you add a comment similar to the one Kevin used in the commit you linked to? That makes no sense whatsoever, so it'll need some explanation for future readers. |
olifre
force-pushed
the
ruby-2.4-compatibility
branch
from
ce608f3
to
72df761
Compare
Since Ruby 2.4, it is required to pass a 4 byte password, even if the key has no password at all, otherwise it fatals out. This leads to ugly workarounds such as these: https://github.com/github/octocatalog-diff/blob/6093d3c24b0be8045d779b1f6cf2e56367e2e8fb/lib/octocatalog-diff/util/httparty.rb#L127 Since we know these keys always have no password, we can just use 1234.
olifre
force-pushed
the
ruby-2.4-compatibility
branch
from
72df761
to
d6077ac
Compare
I fully agree. Such design decisions really change my view of the programming language as a whole...
Good idea! Did that just now and updated the commit, let me know if the comment is clear enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ruby 2.4, it is required to pass a 4 byte password,
even if the key has no password at all, otherwise it fatals out.
This leads to ugly workarounds such as these:
https://github.com/github/octocatalog-diff/blob/6093d3c24b0be8045d779b1f6cf2e56367e2e8fb/lib/octocatalog-diff/util/httparty.rb#L127
Since we know these keys always have no password, we can just use 1234.
Maybe somebody should open up a Ruby bug about this stupid design decision.