This should be a != compare as if the node's puppet server is not the… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CA server (this means folks have a different CA than master) then configure this resource to copy over the public certs from the fileserver endpoint created.
There is no reliable way to definitively identify the difference between compile masters and agent nodes. Therefore, we just sync to all non-CA nodes and let the user classify to avoid syncing to agents, if they so choose.
|
The name of the It's better to not attempt the logic than to do it in an unreliable fashion, so I just removed it. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… CA server (this means folks have a different CA than master) then configure this resource to copy over the public certs from the fileserver endpoint created.
In my puppet env we have our puppet master separate from the CA server. With the code prior to this change, nothing happened on the master where the certificates class was present. When I changed this compare it did what I would expect. I don't think we need to have those certs synced if the puppet server is the same as the CA since it'll already have everything, yes?