Remove serialized class from transactionstore #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet tries to persist data between runs for use in calculating intentional change vs. unintentional drift. Unfortunately, it's just yaml serialized to disk, meaning both that it's an invalid class when Puppet tries to reload it for the next run, and it means that the plain text form of the secret was written to cache. Bad Puppet! This corrects both of those issues, with the slight side effect that node_encrypt files probably won't ever show up as intentional change if the content is modified after the first write. That's not a huge deal, but I'm tracking it in #42 for eventual correction. Fixes #34 Co-authored-by: Aleksei <lexa@ihpu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet tries to persist data between runs for use in calculating
intentional change vs. unintentional drift. Unfortunately, it's just
yaml serialized to disk, meaning both that it's an invalid class when
Puppet tries to reload it for the next run, and it means that the plain
text form of the secret was written to cache. Bad Puppet!
This corrects both of those issues, with the slight side effect that
node_encrypt files probably won't ever show up as intentional change if
the content is modified after the first write. That's not a huge deal,
but I'm tracking it in #42 for eventual correction.
Fixes #34
Co-authored-by: Aleksei lexa@ihpu.org