Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AIX machines with IPv6 disabled. #142

Merged
merged 2 commits into from Mar 21, 2014
Merged

Fix for AIX machines with IPv6 disabled. #142

merged 2 commits into from Mar 21, 2014

Conversation

apenney
Copy link
Contributor

@apenney apenney commented Mar 21, 2014

This attempts to handle the fact that NTP seems to explode if IPv6
is disabled on AIX, ntp becomes unable to parse the -6 lines that
we rely on in $restrict. It also apparently predates the KoD filtering
capabilities. As this stands for 'Kiss of Death' we certainly want to
retain this filtering capability for other distributions and operating
systems.

Ashley Penney added 2 commits March 21, 2014 14:05
This attempts to handle the fact that NTP seems to explode if IPv6
is disabled on AIX, ntp becomes unable to parse the -6 lines that
we rely on in $restrict.  It also apparently predates the KoD filtering
capabilities.  As this stands for 'Kiss of Death' we certainly want to
retain this filtering capability for other distributions and operating
systems.
@puppetlabs-jenkins
Copy link
Collaborator

🔴 Test failed.
Refer to this link for build results: http://jenkins-modules.delivery.puppetlabs.net/job/puppetlabs-grizzly%20pull%20requests/9/

@hunner
Copy link
Contributor

hunner commented Mar 21, 2014

What happens on AIX when there is IPv6? Should this PR target the supported branch?

@hunner
Copy link
Contributor

hunner commented Mar 21, 2014

Why is puppetlabs-grizzly commenting here?

@hunner
Copy link
Contributor

hunner commented Mar 21, 2014

Also, if someone wants to override the default restrict lines, they just have to pass restrict to the base class. AIX without IPv6 could always do that. (Not as good as detecting IPv6, but still a plausible workaround)

@apenney
Copy link
Contributor Author

apenney commented Mar 21, 2014

The current situation with this would be AIX users would have to pass their own IPv6 stuff in. $ipaddress6 isn't supported in AIX so we have no way to autodetermine if it's enabled, and only AIX fails if it's disabled (as far as I'm aware).
Either way AIX fails with the kod line on ipv4 and ipv6 and we want that on all other distributions. I would feel weird about having a special README thing that says AIX users have to pass custom restrict lines, but that's a totally valid potential workaround. Supported modules doesn't imply "always works with the defaults", I don't think.

@apenney
Copy link
Contributor Author

apenney commented Mar 21, 2014

Also I never like targeting older branches and merging up, it just feels so wrong to me, that's why I always target master and backport to 3.0.x branches. I can't shake it, it feels horribly wrong to target anything but master with stuff I want to carry forward..

apenney pushed a commit that referenced this pull request Mar 21, 2014
Fix for AIX machines with IPv6 disabled.
@apenney apenney merged commit f29b589 into puppetlabs:master Mar 21, 2014
@apenney apenney deleted the aix-ipv6-fixes branch March 21, 2014 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants