(#14457) Add FreeBSD support for the NTP class #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Whopper92 You need to rebase and add the ticket number to the subject of your commit. (#14457) Add FreeBSD support for the NTP class |
|
Also your spec tests are failing. 2) ntp test platform specific resources for operating system freebsd should use the freebsd ntp servers by default
Failure/Error: (content.split("\n") & expected_lines).should == expected_lines
expected: ["0.freebsd.pool.ntp.org", "1.freebsd.pool.ntp.org", "2.freebsd.pool.ntp.org", "3.freebsd.pool.ntp.org"]
got: [] (using ==)
# ./spec/classes/ntp_spec.rb:68
3) ntp test platform specific resources for operating system freebsd
Failure/Error: it { should contain_package('ntp').with_ensure('present') }
expected that the catalogue would contain Package[ntp]
# ./spec/classes/ntp_spec.rb:81
4) ntp test platform specific resources for operating system freebsd should allow package ensure to be overridden
Failure/Error: subject.should contain_package('ntp').with_ensure('latest')
expected that the catalogue would contain Package[ntp]
# ./spec/classes/ntp_spec.rb:91
|
|
@blkperl The spec tests are all passing now. |
|
@Whopper92 @blkperl looking at this now. |
kbarber
added a commit
that referenced
this pull request
May 14, 2012
(#14457) Add FreeBSD support for the NTP class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for FreeBSD to the NTP class.