(#11156) Fix module path fixtures so rspec works in most rubies #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this module was using an experimental pattern using mktmpdir for creating its module path for rspec-puppet to use, which has since been deprecated in favour of a static directory. This was largely because ntp was one of the earlier modules we tried to make work in Jenkins. This change aligns the module to use the same pattern used in the rspec- puppet setup stage: https://github.com/rodjek/rspec-puppet/blob/master/lib/rspec-puppet/setup.rb This should stop the problems with Ruby 1.8.5 complaining about a lack of mktmpdir, and also make it more consistent with other modules in the wild.
justinstoller
added a commit
that referenced
this pull request
May 14, 2012
…pet_tests (#11156) Fix module path fixtures so rspec works in most rubies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this module was using an experimental pattern using mktmpdir for
creating its module path for rspec-puppet to use, which has since been
deprecated in favour of a static directory. This was largely because ntp was
one of the earlier modules we tried to make work in Jenkins.
This change aligns the module to use the same pattern used in the rspec-
puppet setup stage:
https://github.com/rodjek/rspec-puppet/blob/master/lib/rspec-puppet/setup.rb
This should stop the problems with Ruby 1.8.5 complaining about a lack of
mktmpdir, and also make it more consistent with other modules in the wild.