Enable the ability to set interfaces #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's what setting interface listen is useful for: http://serverfault.com/questions/475635/how-to-prevent-ntpd-to-listen-on-0-0-0-0123 |
| @@ -15,6 +15,7 @@ | |||
| $panic = $ntp::params::panic, | |||
| $preferred_servers = $ntp::params::preferred_servers, | |||
| $restrict = $ntp::params::restrict, | |||
| $interfaces = $ntp::params::interfaces, | |||
There was a problem hiding this comment.
Could you use the validate_array() on this?
|
Could you update the readme with the new parameter? https://github.com/puppetlabs/puppetlabs-ntp#parameters Can you add tests? Unit tests would be okay. |
Allow the settings of interfaces. If specified, the wildcard interface will be ignored and the specified interfaces list will be enabled for listening. This is important on Openstack control nodes where Neutron can create dozens or even hundreds of interfaces. When new interfaces are added it causes ntp to rescan. Specificying the interface list prevents this from occuring.
|
All comments addressed |
hunner
added a commit
that referenced
this pull request
Jun 27, 2014
Enable the ability to set interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the settings of interfaces. If specified, the wildcard
interface will be ignored and the specified interfaces list will be
enabled for listening. This is important on Openstack control nodes
where Neutron can create dozens or even hundreds of interfaces. When new
interfaces are added it causes ntp to rescan. Specificying the interface
list prevents this from occuring.