Switch over to using puppet() #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ | |||
| on host, "/bin/echo '' > #{host['hieraconf']}" | |||
| end | |||
| on host, "mkdir -p #{host['distmoduledir']}" | |||
| on host, 'puppet module install puppetlabs-stdlib', :acceptable_exit_codes => [0,1] | |||
| on host, puppet('module','install','puppetlabs-stdlib'), { :acceptable_exit_codes => [0,1] } | |||
There was a problem hiding this comment.
Instead we should use puppet_module_install('puppetlabs-stdlib') also you don't need the ',' in between each command you can pass as a single string
There was a problem hiding this comment.
How do you use puppet_module_install to install dependencies from the forge? I'm not finding that...
There was a problem hiding this comment.
This makes sure the path is correct for Solaris.
underscorgan
force-pushed
the
solaris_spec_updates
branch
from
e988887
to
5c9cb4f
Compare
cyberious
added a commit
that referenced
this pull request
Sep 12, 2014
Switch over to using puppet()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the path is correct for Solaris.