(MODULES-1479) Add package_manage parameter #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
working very well for me 👍 |
|
BTW, it would be good if that's set to |
juniorsysadmin
force-pushed
the
package-manage-parameter
branch
from
16ec97e
to
1c2b9d1
Compare
|
Are there any reasons not to default to package_manage = |
|
@juniorsysadmin Even FreeBSD 3.x came with ntp in base, so that's safe. If anybody did build a world with |
Set package_manage to false on FreeBSD by default.
juniorsysadmin
force-pushed
the
package-manage-parameter
branch
from
1c2b9d1
to
5d821a8
Compare
|
Updated commit to fix acceptance test and make package_manage default to false on FreeBSD |
hunner
added a commit
that referenced
this pull request
Jan 8, 2015
(MODULES-1479) Add package_manage parameter
Closed
hunner
added a commit
to hunner/puppetlabs-ntp
that referenced
this pull request
Jan 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in MODULES-1479, certain FreeBSD base installations already include the base version of ntp and FreeBSD users don't want the ntp module to manage the package on these systems.
This PR uses ideas from PR #154 , which for whatever reason has stalled.
@sethlyons - Is this missing anything?