Broadcast and auth #238
Merged
Broadcast and auth #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you think you can add a test to spec/classes/ntp_spec? |
|
Ok; I added 4 tests based on the value of the two parameters. It appears to apply fine but I am unsure about the placement in the ntp_spec file, please review it with cautious eyes :) |
| @@ -27,6 +30,10 @@ interface listen <%= interface %> | |||
| <% end -%> | |||
| <% end -%> | |||
|
|
|||
| <% if @broadcastclient == true %> | |||
There was a problem hiding this comment.
please turn this %> into a -%>
|
looks good to me (except for the comment above). |
add the two options "broadcastclient" and "disable auth"
mpuel
force-pushed
the
broadcast_and_auth
branch
from
b2ecd5b
to
ab5804c
Compare
|
Ok, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this patch enables two configuration options in ntp.conf : the broadcast mode (the simple way) and the disabling of authentication.
Would you mind envisaging to merge those changes ?