add key distribution #314
Merged
add key distribution #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,7 +176,7 @@ Disables the monitoring facility in NTP. Valid options: 'true' or 'false'. Defau | |||
|
|
|||
| Specifies an NTP driftfile. Valid options: string containing an absolute path. Default value: '/var/lib/ntp/drift' (except on AIX and Solaris) | |||
|
|
|||
| #### `fudge` | |||
There was a problem hiding this comment.
This space is supposed to be there, actually http://spec.commonmark.org/0.24/#atx-headings
There was a problem hiding this comment.
Ok. thank you for the link. I'll revert the changes.
|
Looks good! Could you update this acceptance test to use the new parameter instead of puppetlabs-ntp/spec/acceptance/ntp_parameters_spec.rb Lines 98 to 113 in 9937d96 |
| @@ -210,14 +212,20 @@ Specifies the complete path and location of the MD5 key file containing the keys | |||
|
|
|||
| Specifies the key identifier to use with the ntpdc utility program. Valid options: value in the range of 1 to 65,534 inclusive. Default value: ' ' | |||
|
|
|||
| #### `keys_trusted`: | |||
| ####`keys_template` | |||
There was a problem hiding this comment.
Do you really need this parameter? We don't usually add parameters to change the template used, preferring that PRs be sent to expand the existing templates. So would it work for you to not add this parameter?
hunner
added a commit
to hunner/puppetlabs-ntp
that referenced
this pull request
Mar 11, 2016
The keys_file defaults to /etc/ntp/keys on many platforms, but the packages do not create that directory. There is a parameter, config_dir that can be used to manage this directory, though in our acceptance tests there was a line that did an mkdir of this directory which was removed in PR puppetlabs#314 and covered up the fact that the module would not work by default on many platforms. This should get the tests working again, and update the debian/ubuntu defaults to their documented defaults. Both Debian and Ubuntu actually specify /etc/ntp.keys as the default. And freebsd, sles, opensuse, and archlinux. RedHat is the only OS with /etc/ntp/keys as the true default, against the ntpd standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to distribute keys to our nodes. And this works for me.