Make service ntp started on boot -> service 'ntp' { enable=>$enable... #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @codingtony. Would you mind rebasing this on master so that we can finally get this merged in? |
|
@RColeman I'm pretty sure I messed things up with this merge, I'm not familiar with the process, could you help me out with this ? |
|
The end-result looks good @codingtony but I see what you mean about all the superfluous commits. I'll see what I can do to squash them down after lunch PST. Thanks! |
|
@RColeman is there a way I can fix it myself ? |
|
@codingtony have a look here: |
Puppet-lint was complaining about "ensure found on line but it's not the first attribute on line 109". Trivial fix (swapped the ensure and the name). Also, the README didn't mention Debian or CentOS, but the comment block in init.pp did. I added both to the README. I happen to be using this with Debian unstable, but I haven't tested it extensively enough to say "yep, this works". It, however, works for me.
…re ntp to start on boot.
NTP servers should not restrict themselves to 127.0.0.1, and this commit adds a `restrict` parameter to enable/disable this configuration block in the relevent templates.
0.2.0 is a backwards compatible feature and bug-fix release. Since 0.1.0, support for Amazon Linux was added, fixes for style were implemented and support was added for tinker_panic. tinker_panic will default to on when the fact is_virtual is true.
Conflicts: manifests/init.pp
|
I think it's better now... |
|
Awesome, thanks @codingtony. I'm merging this in now. |
ryanycoleman
pushed a commit
that referenced
this pull request
Dec 10, 2012
Make service ntp started on boot -> service 'ntp' { enable=>$enable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the "enable" property to make ntp start on boot