(FM-5598) NTP 5.0.0 features and release-prep #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
reviewed
Oct 14, 2016
| #Otherwise use the defined erb/epp template, or use default | ||
| if $ntp::config_epp and $ntp::config_template { | ||
| fail('Cannot supply both config_epp and config_template templates for ntp config file.') | ||
| }elsif $ntp::config_template { |
There was a problem hiding this comment.
what's up with the cuddled elsifs here?
There was a problem hiding this comment.
it would have passed lint, fixed anyways, because humans still >> machines.
rspec-puppet-facts is now provided by the default modulesync configs
The following changes will only run (well) on puppet 4.5 or later. Therefore we can drop the puppet 3 testing on travis, and add more in-depth testing for puppet 4. Update the version_requirement in metadata.json. We'll also require the newest version of stdlib for the validate_legacy and deprecation functions. Since we are dropping compatibilty with puppet 3, users of that version would experience breakage with the new ntp version, therefore this is a major version bump.
Note that data-in-modules is currently still marked as "experimental", but will be finalized soon, supporting what is currently used here.
This requires more work to add depreciations to the current hodge-podge, to tighten down what is allowed. Many of the unchecked edge-cases will result in a broken ntp config anyways, but just fixing it would elevate issues in this area from broken ntp service to broken catalog.
After this change, the module uses, and can accept EPP templates through the config_epp and step_tickers_epp parameters. ERB templates are still valid through the config_template and step_tickers_template parameters. Backwards-Compatibility-Saved-By: Wilson McCoubrey <wilson@puppet.com>
This updates all ntp class params to allow proper puppet 4 type checking, while still retaining the possibility to accept all formerly allowed values. Values that were allowed by the previous validation code, but will not pass the new type validation will be flagged with a deprecation warning. This requires the EPP template commit, so that all users of these values are prepared to handle the new values.
Copy-Edited-By: jbondpdx <jean@puppet.com>
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.