(MODULES-3397) fix default Solaris settings #362
Conversation
|
@vchepkov Howdy! I looked over this PR and it seems pretty straightforward. I'll need to bring in @DavidS to verify this is correct. Can I ask you to do a couple of things for me in the interim? I know this change looks possibly trivial, but we'd like to get a JIRA ticket assigned on it so we have something to point to for release notes (and for tracking purposes). If you could file a ticket at https://tickets.puppet.com/browse/MODULES (create button in top row). Select ntp as part of the components and fill in as many details as you can. Then let us know what ticket that is. The second thing we'll need you to do is prepend the git commit message with the ticket number that you get back, something like "(MODULES-1234)" - so your commit would look like Thanks and apologies on not getting to this sooner! cc @DavidS for correctness. |
|
I actually have created ticket sometime ago |
There was a problem hiding this comment.
The changes look very straightforward. I don't know whether the package names are correct, so we'll have @DavidS or @hunner review that. I requested changes to file a ticket and associate this commit with that ticket. Once that is done, this looks good to me, pending whether the package names are correct or not.
|
@vchepkov Fantastic. Do you need any help associating the commit with the ticket? |
|
I amended commit message to include ticket number. thanks for the help |
|
@vchepkov not to nitpick too much, but we are hoping for exactly as I prescribed. "(MODULES-3397) Fix default Solaris settings" - the important bits being that the JIRA ticket is surrounded by parentheses and there is no other separator between that and the commit message. If you want a more in depth review of contributing guidelines and our hope for the commit body as well, please review https://github.com/puppetlabs/puppetlabs-ntp/blob/master/CONTRIBUTING.md. HTH |
Module creates NTP v4 compatible configuration. Correct names for NTP v4 packages and service
|
My bad, fixed |
DavidS
changed the title
This finalizes the cleanup from 8a82c5f by making the solaris version supported by each data file clear.
|
@vchepkov thank you very much for your contribution! |
Module creates NTP v4 compatible configuration.
Correct names for NTP v4 packages and service