Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml to version 5 #394

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Update yaml to version 5 #394

merged 1 commit into from
Sep 13, 2017

Conversation

danielhoherd
Copy link
Contributor

This change updates the hiera.yaml to version 5 and removes all complaints about this package from puppet version 4.10 runs.

@ColinHebert
Copy link

What's the status of this one? It'd be nice to get rid of the warning on recent versions of puppet

@danielhoherd danielhoherd reopened this Jul 3, 2017
@danielhoherd
Copy link
Contributor Author

@ColinHebert fixed.

@trunet
Copy link

trunet commented Sep 8, 2017

this fixes https://tickets.puppetlabs.com/browse/MODULES-5185

@danielhoherd
Copy link
Contributor Author

@ColinHebert Is there anything more I need to do in order to get this merged?

@ColinHebert
Copy link

Errr I'm not the owner of this repository. cc @tphoney ^

@tphoney
Copy link
Contributor

tphoney commented Sep 12, 2017

Yo, @pmcmaw is going to have a look over this PR. Thanks for the contribution 👍

Hi @ColinHebert

@pmcmaw pmcmaw merged commit 0b8ff3f into puppetlabs:master Sep 13, 2017
@pmcmaw
Copy link
Contributor

pmcmaw commented Sep 13, 2017

@danielhoherd Many thanks for your contribution, it is much appreciated! 👍

@pmcmaw
Copy link
Contributor

pmcmaw commented Oct 27, 2017

@danielhoherd, This is currently causing issues with compatibility.
I plan on reverting this PR, releasing and then putting this back in and bumping compatibility versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants