Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml to version 5 #428

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Update yaml to version 5 #428

merged 1 commit into from
Oct 27, 2017

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Oct 27, 2017

Putting in changes to update the yaml to hiera version 5. This work was previously done by @danielhoherd although I was unable to cherry pick the commit.
The changes needed to be reverted as the following issues were seen:

This PR will be released as part of a x version bump and a bump in metadata.

The PR where the changes were reverted: #425

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Oct 27, 2017

@danielhoherd I was unable to cherry pick your commit from #394 as your commit came from an ‘unknown repository’, this is the commit to put your changes back in. Again, many thanks for your contribution. I am working on releasing NTP 7.0.0 with your changes.

@willmeek willmeek merged commit fe01174 into puppetlabs:master Oct 27, 2017
@danielhoherd
Copy link
Contributor

@pmcmaw Thanks for the info. I guess "unknown repository" is because I deleted my fork after my changes were merged in #394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants