Don't use 'inherits' in config, install and service #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the ntp class contains the other ntp classes ntp::config, ntp::install and ntp::service it is neither necessary nor useful for these classes to inherit from the "main" ntp class. Letting the classes ntp::config, ntp::install and ntp::service inherit from ntp is also counter all recommendations in the Puppet documentation. The puppetlabs-ntp module is widely regarded as a "poster child" for designing Puppet modules and is often used as reference by Puppet newcomers. It should not make use of deprecated and useless or confusing patterns. See also puppetlabs/puppet-docs#801
|
Great PR @antaflos !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ntp class contains the other ntp classes ntp::config,
ntp::install and ntp::service it is neither necessary nor useful for
these classes to inherit from the "main" ntp class.
Letting the classes ntp::config, ntp::install and ntp::service inherit
from ntp is also counter all recommendations in the Puppet
documentation. The puppetlabs-ntp module is widely regarded as a "poster
child" for designing Puppet modules and is often used as reference by
Puppet newcomers. It should not make use of deprecated and useless or
confusing patterns.
See also puppetlabs/puppet-docs#801