Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit configuration for a local clock as time source if running on a VM. #49

Conversation

alexjfisher
Copy link
Contributor

Quoting http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1006427
'It is also important not to use the local clock as a time source, often referred to as the Undisciplined Local Clock.'

Quoting http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1006427
'It is also important not to use the local clock as a time source, often referred to as the Undisciplined Local Clock.'
@ryanycoleman
Copy link

Awesome, thank you @alexjfisher!

I want to include a spec test to prevent regressions on this behavior. Maybe I'll have time today to take a crack at it. Otherwise, this is certainly eligible to merge.

ryanycoleman pushed a commit that referenced this pull request Apr 4, 2013
This commit provides a spec test for pull request #49 and commit
01273c5 which specifies that virtual
machines should not use the local clock. This test attempts to protect
against a regression on that statement.
@ryanycoleman
Copy link

Thanks again @alexjfisher. Merging this and #54.

ryanycoleman pushed a commit that referenced this pull request Apr 4, 2013
…clock_for_vms

Omit configuration for a local clock as time source if running on a VM.
@ryanycoleman ryanycoleman merged commit 1ce3e73 into puppetlabs:master Apr 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants