Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service hasstatus and hasrestart atributes #499

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

ffapitalle
Copy link

@ffapitalle ffapitalle commented Jan 29, 2019

Hi, this is my first pull request to this project. Let me know any changes that I need to do.

This PR adds class parameters to modify service hasstatus and hasrestart atributes, that are currently fixed to true.
Motivation of this change is that under some circumstances, a service restarts fails as if ntp process was slowly to stop, and the new one starting can't bind to address / port.

puppet-agent[28907]: (/Stage[main]/Ntp::Config/File[/etc/ntp.conf]/content) content changed '{md5}401589661b64e90b77c9c7f3f6a88df8' to '{md5}d79f2e85f4b263535186c092f99ed5ff'
 systemd[1]: Stopping LSB: Start NTP daemon...
 ntp[29587]:  * Stopping NTP server ntpd
 ntp[29587]:    ...done.
 systemd[1]: Stopped LSB: Start NTP daemon.
 systemd[1]: Starting LSB: Start NTP daemon...
 ntp[29600]:  * Starting NTP server ntpd
 ntpd[29608]: ntpd 4.2.8p4@1.3265-o Fri Jul  6 20:10:51 UTC 2018 (1): Starting
 ntpd[29608]: Command line: /usr/sbin/ntpd -p /var/run/ntpd.pid -g -u 112:121
 ntp[29600]:    ...done.
 systemd[1]: Started LSB: Start NTP daemon.
 puppet-agent[28907]: (/Stage[main]/Ntp::Service/Service[ntp]) Triggered 'refresh' from 1 event
 ntpd[29611]: proto: precision = 0.052 usec (-24)
 ntpd[29611]: restrict default: KOD does nothing without LIMITED.
 ntpd[29611]: restrict ::: KOD does nothing without LIMITED.
 ntpd[29611]: unable to bind to wildcard address :: - another process may be running - EXITING
 ntpd[8066]: ntpd exiting on signal 15 (Terminated)

@tphoney
Copy link
Contributor

tphoney commented Feb 14, 2019

Thanks @ffapitalle this is really really great work. Merging it now.

Awesome 👍

@tphoney tphoney merged commit 68925ea into puppetlabs:master Feb 14, 2019
@ffapitalle
Copy link
Author

Thanks @ffapitalle this is really really great work. Merging it now.

Awesome

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants