Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Make mode for logfile configurable #590

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

tmanninger
Copy link

I need the set custom permissions for the ntp logfile (debian hardening guidelines).
This pull request adds an option to change the default permissions for the logfile

@tmanninger tmanninger requested a review from a team as a code owner November 23, 2020 12:28
@puppet-community-rangefinder
Copy link

ntp::config is a class

that may have no external impact to Forge modules.

ntp is a class

Breaking changes to this file WILL impact these 22 modules (exact match):
Breaking changes to this file MAY impact these 9 modules (near match):

This module is declared in 121 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@michaeltlombardi michaeltlombardi self-assigned this Nov 23, 2020
@michaeltlombardi michaeltlombardi changed the title Set mode for logfile (MAINT) Make mode for logfile configurable Nov 23, 2020
Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this patch, @tmanninger!

@michaeltlombardi michaeltlombardi merged commit 7e689c9 into puppetlabs:main Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants