Allow setting user and group permissions of the NTP logfile

[Kristijan]

The Puppet file resource manifests/config.pp assumes that the user and group ntp exist on all supported operating systems. This is not the case (at least) for AIX 7.1, AIX 7.2, and Solaris 11. This results in the Puppet agent run failing to modify the user and group permissions of $ntp::logfile.

I'm proposing that the user and group values be turned into parameters, with the default user and group in data/common.yaml remaining as ntp as to not break any existing configurations.

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

ntp::config is a class

that may have no external impact to Forge modules.

ntp is a class

Breaking changes to this file WILL impact these 23 modules (exact match):

• tse-time
• oris-appserver
• glorpen-g_server
• maestrodev-maestro_nodes
• fervid-secure_linux_cis
• nrvale0-site
• elsopapa-cishardening
• karume-openstack
• tomkrieger-security_baseline
• openshift-openshift_origin
• continuent-tungsten
• pltraining-classroom_legacy
• ULHPC-public_profiles
• mojolingo-openshift
• cohdjn-cisecurity
• mikegleasonjr-server
• narasimhasv-openstack
• gennadyvoronkov-dcos
• sdodson-openshift_origin
• puppetlabs-openstack
• alkivi-alkivi_base
• cnafsd-os_base
• geoffwilliams-r_profile

Breaking changes to this file MAY impact these 9 modules (near match):

• willdurand-bazinga
• example42-psick
• erwbgy-system
• jethrocarr-soe
• eNovance-cloud
• arioch-icinga
• ghoneycutt-common
• autostructure-secure_linux_cis
• puppet-system

This module is declared in 122 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[carabasdaniel]

Hi @Kristijan, thank you for your contribution, this looks great 👍