Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archlinux now also has an osfamily fact #69

Merged
merged 2 commits into from
Jul 12, 2013
Merged

Archlinux now also has an osfamily fact #69

merged 2 commits into from
Jul 12, 2013

Conversation

simonsd
Copy link
Contributor

@simonsd simonsd commented Jul 10, 2013

Since facter 1.7.0 Archlinux also has a separate osfamily (http://projects.puppetlabs.com/issues/17521)

Signed-off-by: Dave Simons <dave@inuits.eu>
@apenney
Copy link
Contributor

apenney commented Jul 11, 2013

This is awesome but it breaks a few things! If you look at the travis link in here you'll see various spec tests break. Could you take a look at these with an eye to fixing them up? I would totally appreciate it. I'm hoping to get this merged it by tomorrow so it makes it to 1.0.0 so if you can't let me know and I'll nab this and do the rest. :)

Signed-off-by: Dave Simons <dave@inuits.eu>
@simonsd
Copy link
Contributor Author

simonsd commented Jul 12, 2013

fixed up the spec tests.
should work fine now :)

@apenney
Copy link
Contributor

apenney commented Jul 12, 2013

Awesome, thanks for this, merging it now.

apenney added a commit that referenced this pull request Jul 12, 2013
Archlinux now also has an osfamily fact
@apenney apenney merged commit 8ecb0c9 into puppetlabs:master Jul 12, 2013
hunner added a commit to hunner/puppetlabs-ntp that referenced this pull request Jul 15, 2013
This reverts commit 8ecb0c9, reversing
changes made to 4e815f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants