Merge all the templates together, add a few new features to help with the merge. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 29, 2013 17:09
`driftfile` [String]: Allows the setting of the driftfile location. `keys_enable` [Boolean]: Should the ntp keys option be enabled? `keys_file` [String]: Where are the keys stored? `keys_trusted` [Array]: List of keys to trust. `keys_requestkey` [String]: Request key to use. `keys_controlkey` [String]: Control key to use. If keys_enable is set then the directory that keysfile is stored in is created (recursively). Currently we don't manage the keys file but that is an option to be added.
Add a single ntp.conf.erb as the standard template going forward, to ease the maintenance burden of adding features to this module.
This adds: `preferred_servers` [Array]: The servers to prefer. As requested by Erik Dalén!
We're following (where possible) the pattern of having parameters only exist on interface classes. As ntp::config and ntp::install are just internal, private, classes, these don't make sense to allow changes to.
A lot of changes here, primarily to unify the spec testing in a single spec file to reflect the changes to the private ntp::config and ::install classes. As a side effect make sure we properly test each supported distribution (including Gentoo properly) and prefer to use 'content' => /blah/ rather than other methods of testing file contents.
apenney
pushed a commit
that referenced
this pull request
Jul 31, 2013
Merge all the templates together, add a few new features to help with the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges together all the templates into a single template (still overridable) and adds:
keys_enable,keys_trusted,keys_controlkey,keys_requestkey,keys_file: Parameters to let you configure ntp keysdriftfile: Lets you set the driftfile location.preferred_servers: Lets you set which servers are to be preferred.