Skip to content

Loading…

Use include-style declarations for common classes #96

Merged
merged 1 commit into from

3 participants

@croomes

Classes that are used commonly outside this module should be included
where possible to avoid duplicate declaration errors. Many sites
will have their own base profiles that already define ntp and
firewall rules.

@croomes croomes Use include-style declarations for common classes
Classes that are used commonly outside this module should be included
where possible to avoid duplicate declaration errors.  Many sites
will have their own base profiles that already define ntp and
firewall rules.
0f9429c
@benh57

+1. I applied this locally a while back..

@cmurphy cmurphy merged commit fcc0a76 into puppetlabs:master
@cmurphy

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 16, 2014
  1. @croomes

    Use include-style declarations for common classes

    croomes committed
    Classes that are used commonly outside this module should be included
    where possible to avoid duplicate declaration errors.  Many sites
    will have their own base profiles that already define ntp and
    firewall rules.
Showing with 2 additions and 2 deletions.
  1. +1 −1 manifests/profile/base.pp
  2. +1 −1 manifests/profile/firewall/pre.pp
View
2 manifests/profile/base.pp
@@ -4,7 +4,7 @@
include ::openstack
# everyone also needs to be on the same clock
- class { '::ntp': }
+ include ::ntp
# all nodes need the OpenStack repository
class { '::openstack::resources::repo': }
View
2 manifests/profile/firewall/pre.pp
@@ -20,7 +20,7 @@
}
}
- class { '::firewall': }
+ include ::firewall
# Default firewall rules, based on the RHEL defaults
firewall { '0001 - related established':
Something went wrong with that request. Please try again.