(BOLT-1104) Unify task implementation output #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return information from the package command itself, i.e. yum or apt. Also provide the error message as part of the json object. Directly check the return code of commands instead of storing $? in a variable when we can. Use mktmp and exec to manage stderr.
For example, `yum install vim` will install `vim-enhanced`, but `rpm -q vim` will fail to resolve this.
donoghuc
force-pushed
the
BOLT-1104
branch
3 times, most recently
from
1c421db
to
1d0a5a1
Compare
m0dular
reviewed
Mar 22, 2019
tasks/linux.sh
Outdated
| fi | ||
|
|
||
| # Determine if newer package is available to mirror the ruby/puppet implementation | ||
| upgradable_list=($(sudo apt-get -u -V --assume-no upgrade | grep "\\${PT_name}\\b")) |
There was a problem hiding this comment.
This could probably be simplified to just check the output of apt-get with grep and use the return code. Also, a specific package can be given to apt-get. For example, with an up-to-date puppet-agent
$ cat foo.sh
#!/bin/bash
if sudo apt-get --assume-no upgrade puppet-agent | grep -q 'already the newest version'; then
echo "latest"
else
echo "upgradable"
fi
./foo.sh
latest
Make the bash task implementation more consistent with the ruby/puppet task output. This includes calculating a `latest_version` when a newer version of a packages is available. Note that the important update is to unify the result keys, the values can contain different information based on the implementation.
This commit updates the powershell implementation to report similar keys to the ruby/bash implementations. Similarly the error handling and parameter validation is handled more in line with the service task.
Bolt 1.15.0 includes a new feature for BoltSpec::Run that allows inventory and config to be set by defining bolt_{inventory,config} methods in scope when run_* functions are invoked. This commit refactors acceptance tests to take advantage of the new feature resulting in cleaner code.
m0dular
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improvements to the task implementations making them more robust across platforms. It also ensures that each of the implementations return consistent result keys.