(BOLT-1525) Zypper implementation #143

m0dular · 2019-08-27T16:41:05Z

No description provided.

m0dular · 2019-08-27T16:41:54Z

@donoghuc Can you show me how to set up some SLES boxes for testing when you have some time?

tasks/init.json

tasks/linux.sh

donoghuc · 2019-09-23T20:45:45Z

We can also add sles 11,12,15 to https://github.com/puppetlabs/puppetlabs-package/blob/master/metadata.json

donoghuc · 2019-09-23T21:30:25Z

@m0dular I will have more time tomorrow to figure out the acceptance test stuff. I think all you have to do is add some sles template names from vmpooler to

puppetlabs-package/provision.yaml

Line 16 in 592e752

    
           images: ['redhat-5-x86_64', 'redhat-6-x86_64', 'redhat-7-x86_64', 'redhat-8-x86_64', 'centos-5-x86_64', 'centos-6-x86_64', 'centos-7-x86_64', 'oracle-5-x86_64', 'oracle-6-x86_64', 'oracle-7-x86_64', 'scientific-6-x86_64', 'scientific-7-x86_64', 'debian-8-x86_64', 'debian-9-x86_64', 'ubuntu-1404-x86_64', 'ubuntu-1604-x86_64', 'ubuntu-1804-x86_64', 'win-2008r2-x86_64', 'win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64', 'win-10-pro-x86_64']

then follow something like:

    - bundle exec rake litmus:provision_list[release_checks]
    - bundle exec rake litmus:install_agent
    - bundle exec rake litmus:install_module
    - bundle exec rake litmus:acceptance:parallel

To make sure the tests pass. Also, I would make sure to rebase on master branch and bundle update to make sure everything is current. I ran through this locally and there are for sure failures. Have not had the chance to deep dive into why.

adreyer

if we haven't done a release since we added files this should be a major version bump.

tasks/linux.json

MikaelSmith

Generally looks ok to me.

files/yum.sh

donoghuc · 2019-09-26T23:39:25Z

@puppetlabs/modules I'm having a tough time understanding how this module is tested. When I attempt the following workflow locally:

bundle exec rake litmus:provision_list[release_checks]
bundle exec rake litmus:install_agent
bundle exec rake litmus:install_module
bundle exec rake litmus:acceptance:serial

based based on https://github.com/puppetlabs/puppetlabs-package/blob/master/distelli-manifest.yml
The litmus:acceptance:serial task exits 0 almost instantly. This is what appears to be happening is CI as well? https://pipelines.puppet.com/team-modules/builds/591269 (maybe? i'm finding the pipelines interface for this pretty difficult to make sense of).

When I change to litmus:acceptance:parallel i get a bunch of test failures.

(here is an example of a windows failure)

cas@cas-ThinkPad-T460p:~/working_dir/puppetlabs-package$ bundle exec rake litmus:acceptance:ehbfee6snzdlv8d.delivery.puppetlabs.net
/home/cas/.rbenv/versions/2.5.1/bin/ruby -I/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/lib:/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-support-3.8.2/lib /home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/exe/rspec --pattern spec/acceptance/\*\*\{,/\*/\*\*\}/\*_spec.rb

package task
  install
    installs pry (PENDING: Don't run on Windows)
    returns the version of pry (PENDING: Don't run on Windows)
  install without puppet
    installs rsyslog (PENDING: Don't run on Windows)
  uninstall
    uninstalls pry (PENDING: Don't run on Windows)
    status (PENDING: Don't run on Windows)

windows package task
  install action
    install notepadplusplus.install (FAILED - 1)
  uninstall action
    uninstall notepadplusplus.install (FAILED - 2)
  install specific
    upgrade notepad++ to a specific version (FAILED - 3)
    upgrade notepad++ (FAILED - 4)
  when puppet-agent feature not available on target
    status action fails (FAILED - 5)

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) package task install installs pry
     # Don't run on Windows
     # ./spec/acceptance/init_spec.rb:26

  2) package task install returns the version of pry
     # Don't run on Windows
     # ./spec/acceptance/init_spec.rb:33

  3) package task install without puppet installs rsyslog
     # Don't run on Windows
     # ./spec/acceptance/init_spec.rb:42

  4) package task uninstall uninstalls pry
     # Don't run on Windows
     # ./spec/acceptance/init_spec.rb:54

  5) package task uninstall status
     # Don't run on Windows
     # ./spec/acceptance/init_spec.rb:60


Failures:

  1) windows package task install action install notepadplusplus.install
     On host `ehbfee6snzdlv8d.delivery.puppetlabs.net'
     Failure/Error: apply_manifest(pp)
     RuntimeError:
       apply manifest failed
       ` puppet apply /tmp/manifest_20190926_25544_10quzmv.pp`
       with exit code 1 (expected: [0])
       ====== Start output of failed Puppet apply ======
       puppet.bat : Warning: This method is deprecated, please use the stdlib validate_legacy function,
           + CategoryInfo          : NotSpecified: (Warning:...egacy function,:String) [], RemoteException
           + FullyQualifiedErrorId : NativeCommandError
                           with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 89]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Pattern[]. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 91]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 96]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 97]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Notice: Compiled catalog for ehbfee6snzdlv8d.delivery.puppetlabs.net in environment production in 0.41 seconds
       Notice: /Stage[main]/Chocolatey::Install/Registry_value[ChocolateyInstall environment value]/ensure: created
       Notice: /Stage[main]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
       Notice: Applied catalog in 6.55 seconds
       
       ====== End output of failed Puppet apply ======
       
     # ./spec/acceptance/windows_spec.rb:18:in `block (2 levels) in <top (required)>'

  2) windows package task uninstall action uninstall notepadplusplus.install
     On host `ehbfee6snzdlv8d.delivery.puppetlabs.net'
     Failure/Error: apply_manifest(pp)
     RuntimeError:
       apply manifest failed
       ` puppet apply /tmp/manifest_20190926_25544_10quzmv.pp`
       with exit code 1 (expected: [0])
       ====== Start output of failed Puppet apply ======
       puppet.bat : Warning: This method is deprecated, please use the stdlib validate_legacy function,
           + CategoryInfo          : NotSpecified: (Warning:...egacy function,:String) [], RemoteException
           + FullyQualifiedErrorId : NativeCommandError
                           with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 89]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Pattern[]. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 91]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 96]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 97]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Notice: Compiled catalog for ehbfee6snzdlv8d.delivery.puppetlabs.net in environment production in 0.41 seconds
       Notice: /Stage[main]/Chocolatey::Install/Registry_value[ChocolateyInstall environment value]/ensure: created
       Notice: /Stage[main]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
       Notice: Applied catalog in 6.55 seconds
       
       ====== End output of failed Puppet apply ======
       
     # ./spec/acceptance/windows_spec.rb:18:in `block (2 levels) in <top (required)>'

  3) windows package task install specific upgrade notepad++ to a specific version
     On host `ehbfee6snzdlv8d.delivery.puppetlabs.net'
     Failure/Error: apply_manifest(pp)
     RuntimeError:
       apply manifest failed
       ` puppet apply /tmp/manifest_20190926_25544_10quzmv.pp`
       with exit code 1 (expected: [0])
       ====== Start output of failed Puppet apply ======
       puppet.bat : Warning: This method is deprecated, please use the stdlib validate_legacy function,
           + CategoryInfo          : NotSpecified: (Warning:...egacy function,:String) [], RemoteException
           + FullyQualifiedErrorId : NativeCommandError
                           with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 89]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Pattern[]. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 91]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 96]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 97]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Notice: Compiled catalog for ehbfee6snzdlv8d.delivery.puppetlabs.net in environment production in 0.41 seconds
       Notice: /Stage[main]/Chocolatey::Install/Registry_value[ChocolateyInstall environment value]/ensure: created
       Notice: /Stage[main]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
       Notice: Applied catalog in 6.55 seconds
       
       ====== End output of failed Puppet apply ======
       
     # ./spec/acceptance/windows_spec.rb:18:in `block (2 levels) in <top (required)>'

  4) windows package task install specific upgrade notepad++
     On host `ehbfee6snzdlv8d.delivery.puppetlabs.net'
     Failure/Error: apply_manifest(pp)
     RuntimeError:
       apply manifest failed
       ` puppet apply /tmp/manifest_20190926_25544_10quzmv.pp`
       with exit code 1 (expected: [0])
       ====== Start output of failed Puppet apply ======
       puppet.bat : Warning: This method is deprecated, please use the stdlib validate_legacy function,
           + CategoryInfo          : NotSpecified: (Warning:...egacy function,:String) [], RemoteException
           + FullyQualifiedErrorId : NativeCommandError
                           with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 89]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Pattern[]. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 91]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 96]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 97]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Notice: Compiled catalog for ehbfee6snzdlv8d.delivery.puppetlabs.net in environment production in 0.41 seconds
       Notice: /Stage[main]/Chocolatey::Install/Registry_value[ChocolateyInstall environment value]/ensure: created
       Notice: /Stage[main]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
       Notice: Applied catalog in 6.55 seconds
       
       ====== End output of failed Puppet apply ======
       
     # ./spec/acceptance/windows_spec.rb:18:in `block (2 levels) in <top (required)>'

  5) windows package task when puppet-agent feature not available on target status action fails
     On host `ehbfee6snzdlv8d.delivery.puppetlabs.net'
     Failure/Error: apply_manifest(pp)
     RuntimeError:
       apply manifest failed
       ` puppet apply /tmp/manifest_20190926_25544_10quzmv.pp`
       with exit code 1 (expected: [0])
       ====== Start output of failed Puppet apply ======
       puppet.bat : Warning: This method is deprecated, please use the stdlib validate_legacy function,
           + CategoryInfo          : NotSpecified: (Warning:...egacy function,:String) [], RemoteException
           + FullyQualifiedErrorId : NativeCommandError
                           with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 89]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Pattern[]. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 91]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 96]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Warning: This method is deprecated, please use the stdlib validate_legacy function,
                           with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["C:/ProgramData/PuppetLabs/code/environments/production/modules/chocolatey/manifests/init.pp", 97]:["C:/tmp/manifest_20190926_25544_10quzmv.pp", 1]
          (location: C:/ProgramData/PuppetLabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
       Notice: Compiled catalog for ehbfee6snzdlv8d.delivery.puppetlabs.net in environment production in 0.41 seconds
       Notice: /Stage[main]/Chocolatey::Install/Registry_value[ChocolateyInstall environment value]/ensure: created
       Notice: /Stage[main]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
       Notice: Applied catalog in 6.55 seconds
       
       ====== End output of failed Puppet apply ======
       
     # ./spec/acceptance/windows_spec.rb:18:in `block (2 levels) in <top (required)>'

Finished in 47.79 seconds (files took 0.81733 seconds to load)
10 examples, 5 failures, 5 pending

Failed examples:

rspec ./spec/acceptance/windows_spec.rb:22 # windows package task install action install notepadplusplus.install
rspec ./spec/acceptance/windows_spec.rb:32 # windows package task uninstall action uninstall notepadplusplus.install
rspec ./spec/acceptance/windows_spec.rb:41 # windows package task install specific upgrade notepad++ to a specific version
rspec ./spec/acceptance/windows_spec.rb:49 # windows package task install specific upgrade notepad++
rspec ./spec/acceptance/windows_spec.rb:59 # windows package task when puppet-agent feature not available on target status action fails

/home/cas/.rbenv/versions/2.5.1/bin/ruby -I/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/lib:/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-support-3.8.2/lib /home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/exe/rspec --pattern spec/acceptance/\*\*\{,/\*/\*\*\}/\*_spec.rb failed

I'm not quite understanding why those are pending tests? Are those covered somewhere else (maybe appveyor?)

NOW for the really weird part. If I run against a target that has failed with the parallel alone it will (always?) pass

cas@cas-ThinkPad-T460p:~/working_dir/puppetlabs-package$ bundle exec rake litmus:acceptance:ikzvc0jyta872xt.delivery.puppetlabs.net
/home/cas/.rbenv/versions/2.5.1/bin/ruby -I/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/lib:/home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-support-3.8.2/lib /home/cas/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/rspec-core-3.8.2/exe/rspec --pattern spec/acceptance/\*\*\{,/\*/\*\*\}/\*_spec.rb

package task
  install
    installs pry
    returns the version of pry
  install without puppet
    installs rsyslog
  uninstall
    uninstalls pry
    status

linux package task
  install action
    installs rsyslog
    errors gracefully when bogus package requested
  status action
    status rsyslog
  uninstall action
    uninstall rsyslog
  upgrade
    upgrade rsyslog

Finished in 46.09 seconds (files took 2.07 seconds to load)
10 examples, 0 failures

I noticed this commit 7766e48#diff-34ca0d47d16a704538c4774f2cc60c0d (with no commit message) moving to the serial rake task. Could this be because the parallel rake task introduced a thread safety bug? I notice it was updated in the travis config as well, but i'm not quite sure why the results are something like

Successful on 3 nodes: ["", "", ""]

For this particular PR we would like to add a SLES target to the acceptance suite. I am not even seeing links to the puppet pipelines checks for recent merges to master. Is there something we can do to verify that adding a sles target to

puppetlabs-package/provision.yaml

Line 16 in 2b841a5

    
           images: ['redhat-5-x86_64', 'redhat-6-x86_64', 'redhat-7-x86_64', 'redhat-8-x86_64', 'centos-5-x86_64', 'centos-6-x86_64', 'centos-7-x86_64', 'oracle-5-x86_64', 'oracle-6-x86_64', 'oracle-7-x86_64', 'scientific-6-x86_64', 'scientific-7-x86_64', 'debian-8-x86_64', 'debian-9-x86_64', 'ubuntu-1404-x86_64', 'ubuntu-1604-x86_64', 'ubuntu-1804-x86_64', 'win-2008r2-x86_64', 'win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64', 'win-10-pro-x86_64']

will be run?

tasks/linux.sh

m0dular · 2019-10-03T22:39:09Z

I ran some sles tests and they passed locally. Hopefully this is everything. We should definitely squash these commits before merging.

donoghuc · 2019-10-04T00:04:06Z

@m0dular Yeah, please squash the commits and capture everything in commit message. We can do a final check and get this merged. You rock.

sheenaajay · 2019-10-04T11:45:58Z

@donoghuc Just an update.TP is working on updating the tests to execute them parallelly. (WIP PR is created for this)

As a workaround to review the PR we can run them locally with parallel task and re-execute tests on failing nodes. Please let us know if you need help with running the job.

m0dular · 2019-10-04T16:57:44Z

Looks like all of the Windows tasks are failing, but obviously I didn't change anything there. In parallel I got this:

┌ [✖] Running against 25 targets.
├── [✔] jqleacgtgpr1jyw.delivery.puppetlabs.net, redhat-5-x86_64
├── [✖] hnnwsybhtqz5wdi.delivery.puppetlabs.net, redhat-6-x86_64
├── [✔] pa5d3e5qd6s3n81.delivery.puppetlabs.net, redhat-7-x86_64
├── [✔] gt2volhtbd1qudl.delivery.puppetlabs.net, redhat-8-x86_64
├── [✔] ix0bhx9tlmf10yr.delivery.puppetlabs.net, centos-5-x86_64
├── [✔] l592qdxfyp7qsye.delivery.puppetlabs.net, centos-6-x86_64
├── [✔] tw69kxr034yqa1m.delivery.puppetlabs.net, centos-7-x86_64
├── [✖] s688j5bzf2a5z85.delivery.puppetlabs.net, oracle-5-x86_64
├── [✔] jlsqqdlr4pgwkgw.delivery.puppetlabs.net, oracle-6-x86_64
├── [✔] rprmcy3iseqlog1.delivery.puppetlabs.net, oracle-7-x86_64
├── [✖] vj0jxirpttsdvmx.delivery.puppetlabs.net, scientific-6-x86_64
├── [✔] ccgs145nsc3cun4.delivery.puppetlabs.net, scientific-7-x86_64
├── [✔] li9lnx2wu24537h.delivery.puppetlabs.net, sles-11-x86_64
├── [✔] xeuwycsnt2scwhd.delivery.puppetlabs.net, sles-12-x86_64
├── [✔] v5ndqf99q2yp44c.delivery.puppetlabs.net, sles-15-x86_64
├── [✔] sqev75ixlcaxhm1.delivery.puppetlabs.net, debian-8-x86_64
├── [✔] q58r1ab5twn2ssm.delivery.puppetlabs.net, debian-9-x86_64
├── [✔] o7gigrveb6b8ir9.delivery.puppetlabs.net, ubuntu-1404-x86_64
├── [✖] k5ftml72z7ewr5v.delivery.puppetlabs.net, ubuntu-1604-x86_64
├── [✔] ni30xyb65dacwkq.delivery.puppetlabs.net, ubuntu-1804-x86_64
├── [✖] s78uc9y2chc3ni3.delivery.puppetlabs.net, win-2008r2-x86_64
├── [✖] yyymdih625l7n9f.delivery.puppetlabs.net, win-2012r2-x86_64
├── [✖] mw1yhmxhiy1hg3y.delivery.puppetlabs.net, win-2016-x86_64
├── [✖] iusy8f8a2unk032.delivery.puppetlabs.net, win-2019-x86_64
└── [✖] sb71g8tksnogktx.delivery.puppetlabs.net, win-10-pro-x86_64

I ran the non-Windows ones that failed manually and they were green:

adrian@Riven:~/Boltdir/site-modules/package$ bundle exec rake litmus:acceptance:hnnwsybhtqz5wdi.delivery.puppetlabs.net
package task
  install
    installs pry
  uninstall
    uninstalls pry
    status

Finished in 13.44 seconds (files took 1.04 seconds to load)
3 examples, 0 failures

adrian@Riven:~/Boltdir/site-modules/package$ bundle exec rake litmus:acceptance:s688j5bzf2a5z85.delivery.puppetlabs.net
package task
  install
    installs pry
    returns the version of pry
  install without puppet
    installs rsyslog
  uninstall
    uninstalls pry
    status

linux package task
  install action
    installs rsyslog
    errors gracefully when bogus package requested
  status action
    status rsyslog
  uninstall action
    uninstall rsyslog
  upgrade
    upgrade rsyslog

Finished in 50.25 seconds (files took 1.13 seconds to load)
10 examples, 0 failures

adrian@Riven:~/Boltdir/site-modules/package$ bundle exec rake litmus:acceptance:vj0jxirpttsdvmx.delivery.puppetlabs.net
package task
  install
    installs pry
  uninstall
    uninstalls pry
    status

Finished in 14.51 seconds (files took 1.18 seconds to load)
3 examples, 0 failures

adrian@Riven:~/Boltdir/site-modules/package$ bundle exec rake litmus:acceptance:k5ftml72z7ewr5v.delivery.puppetlabs.net
package task
  install
    installs pry
    returns the version of pry
  install without puppet
    installs rsyslog
  uninstall
    uninstalls pry
    status

linux package task
  install action
    installs rsyslog
    errors gracefully when bogus package requested
  status action
    status rsyslog
  uninstall action
    uninstall rsyslog
  upgrade
    upgrade rsyslog

Finished in 41.09 seconds (files took 1.46 seconds to load)
10 examples, 0 failures

This commit adds support for the zypper package manager to the Linux package task. Move the helper functions for each manager to its own sourceable script under files/ Tweak the metadata for the Linux task to not use the implementations hash.

sheenaajay · 2019-10-07T12:23:55Z

@m0dular We are working on creating an inventory file outside the test cases.I tried ur changes with the fixes we have. Attaching the screenshot. Windows failures are due to the warning from chocolatey module MODULES-8495 . Everything looks good.

tphoney · 2019-10-07T20:31:28Z

thanks for all your work @m0dular !!! Impressive

Great job tracking this @donoghuc @sheenaajay

m0dular requested a review from donoghuc August 27, 2019 16:41

MikaelSmith reviewed Aug 28, 2019

View reviewed changes

tasks/init.json Outdated Show resolved Hide resolved

m0dular requested a review from MikaelSmith September 4, 2019 16:53

donoghuc self-assigned this Sep 23, 2019

donoghuc reviewed Sep 23, 2019

View reviewed changes

tasks/linux.sh Show resolved Hide resolved

donoghuc reviewed Sep 23, 2019

View reviewed changes

tasks/linux.sh Outdated Show resolved Hide resolved

m0dular force-pushed the aph/BOLT-1525-zypper branch from 4b20ef3 to 435726b Compare September 24, 2019 15:34

m0dular requested a review from a team as a code owner September 24, 2019 15:34

adreyer reviewed Sep 24, 2019

View reviewed changes

donoghuc reviewed Sep 24, 2019

View reviewed changes

tasks/linux.json Show resolved Hide resolved

MikaelSmith reviewed Sep 26, 2019

View reviewed changes

files/yum.sh Show resolved Hide resolved

donoghuc reviewed Sep 26, 2019

View reviewed changes

tasks/linux.sh Show resolved Hide resolved

m0dular force-pushed the aph/BOLT-1525-zypper branch from 435726b to 0d31de1 Compare September 27, 2019 21:58

donoghuc reviewed Oct 2, 2019

View reviewed changes

tasks/linux.sh Show resolved Hide resolved

donoghuc reviewed Oct 2, 2019

View reviewed changes

tasks/linux.sh Outdated Show resolved Hide resolved

(BOLT-1525) Zypper implementation

1f176ec

This commit adds support for the zypper package manager to the Linux package task. Move the helper functions for each manager to its own sourceable script under files/ Tweak the metadata for the Linux task to not use the implementations hash.

m0dular force-pushed the aph/BOLT-1525-zypper branch from 8c04eee to 1f176ec Compare October 4, 2019 19:19

tphoney approved these changes Oct 7, 2019

View reviewed changes

tphoney merged commit 558b09b into puppetlabs:master Oct 7, 2019

sheenaajay added the feature label Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(BOLT-1525) Zypper implementation #143

(BOLT-1525) Zypper implementation #143

m0dular commented Aug 27, 2019

m0dular commented Aug 27, 2019

donoghuc commented Sep 23, 2019

donoghuc commented Sep 23, 2019

adreyer left a comment

MikaelSmith left a comment

donoghuc commented Sep 26, 2019

m0dular commented Oct 3, 2019

donoghuc commented Oct 4, 2019

sheenaajay commented Oct 4, 2019

m0dular commented Oct 4, 2019

sheenaajay commented Oct 7, 2019

tphoney commented Oct 7, 2019

(BOLT-1525) Zypper implementation #143

(BOLT-1525) Zypper implementation #143

Conversation

m0dular commented Aug 27, 2019

m0dular commented Aug 27, 2019

donoghuc commented Sep 23, 2019

donoghuc commented Sep 23, 2019

adreyer left a comment

Choose a reason for hiding this comment

MikaelSmith left a comment

Choose a reason for hiding this comment

donoghuc commented Sep 26, 2019

m0dular commented Oct 3, 2019

donoghuc commented Oct 4, 2019

sheenaajay commented Oct 4, 2019

m0dular commented Oct 4, 2019

sheenaajay commented Oct 7, 2019

tphoney commented Oct 7, 2019