Improve package status consistency on Debian #303
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
previously approved these changes
Apr 14, 2023
smortex
commented
Apr 16, 2023
files/apt.sh
Outdated
| @@ -18,9 +18,9 @@ apt_check_latest() { | |||
| candidate="${candidate#*: }" | |||
|
|
|||
| if [[ $installed != $candidate ]]; then | |||
| cmd_status="$(apt_status "{ \"status\":\"\${Status}\", \"version\":\"${installed}\", \"latest\":\"${candidate}\" }")" | |||
| cmd_status="$(apt_status "{ \"status\":\"\${db:Status-Status}\", \"version\":\"${installed}\", \"latest\":\"${candidate}\" }")" | |||
There was a problem hiding this comment.
We can also hardcode installed here and bellow if you prefer, because it is what we are going to get all the times here and it makes the code slightly more explicit.
There was a problem hiding this comment.
oh good idea, I like that.
In `dpkg-query(1)`, the `Status` field is composed of 3 values [source]:
1. the package wanted status (e.g. `install`, `unknown`),
2. the package status error flag (e.g. `ok`),
3. the package status word (e.g. `installed`, `not-installed`).
When requesting the status of a package, we have this kind of response:
```json
{
"status": "install ok installed",
"version": "7.24.0-1bullseye"
}
```
A similar command targeting a CentOS node return a more consise status:
```json
{
"status": "installed",
"version": "7.24.0-1.el7"
}
```
Hardcode the status value of installed packages to `installed` to match
other operating systems.
[source]:https://manpages.debian.org/bullseye/dpkg/dpkg-query.1.en.html
smortex
force-pushed
the
status-consistency
branch
from
fa6f82b
to
54c2939
Compare
donoghuc
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dpkg-query(1), theStatusfield is composed of 3 values [source]:install,unknown),ok),installed,not-installed).When requesting the status of a package, we have this kind of response:
{ "status": "install ok installed", "version": "7.24.0-1bullseye" }A similar command targeting a CentOS node return a more consise status:
{ "status": "installed", "version": "7.24.0-1.el7" }Hardcode the status value of installed packages to
installedto matchother operating systems.