Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebangs #305

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix shebangs #305

merged 1 commit into from
Apr 19, 2023

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Apr 11, 2023

bash(1) is not always installed in /bin, we can only assume
/bin/sh is a bourne shell, and for any other non-portable shell rely
on env(1) (always available as /usr/bin/env) to find the appropriate
command in $PATH.

While here, remove shebangs from non-executable files.

@smortex smortex requested a review from a team as a code owner April 11, 2023 18:46
@smortex
Copy link
Contributor Author

smortex commented Apr 11, 2023

Relying on a portable shell with bare /bin/sh would also be an enhancement for systems where bash is not needed and allow to add supports for more systems, but this require much more work so is left for later.

@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Apr 19, 2023

@smortex I've went ahead and kicked off a rebase, will merge when green!

`bash(1)` is not always installed in `/bin`, we can only assume
`/bin/sh` is a bourne shell, and for any other non-portable shell rely
on `env(1)` (always available as `/usr/bin/env`) to find the appropriate
command in `$PATH`.

While here, remove shebangs from non-executable files.
@jordanbreen28 jordanbreen28 merged commit 27e9ad8 into puppetlabs:main Apr 19, 2023
@smortex smortex deleted the fix-shebangs branch April 19, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants