Add Compatibility with FreeBSD #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smortex Nice one! |
Add support for managing FreeBSD packages. For now the module depend on bash which is not part of a default FreeBSD install.
jordanbreen28
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Hey @smortex, just had a talk with the team on this one.
I've went ahead and updated the title of this PR, changing the wording from support to compatibility, as we won't be able to offer official support for FreeBSD on this module. This is mainly due to testing restraints, and as we won't be testing this module against FreeBSD we can not officially support and guarantee to maintain this module's compatibility with FreeBSD.
We do feel as if this is a great addition and are happy to accept adding compatibility for FreeBSD with the codebase. So happy to merge - Thanks for your work on this one!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for managing FreeBSD packages. For now the module depend on
bash which is not part of a default FreeBSD install.
Depends on: