Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted lines from yum output #316

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

mlemily
Copy link
Contributor

@mlemily mlemily commented Jun 19, 2023

Summary

Package status pulls yum security information as the latest version when package is up to date and server isn't running latest installed kernel.

Additional Context

See #314 for context

grep yum output for the package name specifically to strip any extraneous lines, similarly to https://github.com/puppetlabs/puppetlabs-package/blob/main/files/zypper.sh#LL5C89-L5C96

Related Issues (if any)

#314

Checklist

Manually verified as below
Before:

bolt > bolt task run package action=status name=rpm -t server0001
Started on server0001...
Finished on server0001:
  {
    "status": "installed",
    "version": "4.14.3-26.el8",
    "latest": "kernel-core-4.18.0-477.13.1.el8_8.x86_64"
  }
Successful on 1 target: server0001
Ran on 1 target in 7.8 sec

After:

dev-bolt > bolt task run package action=status name=rpm -t server0001
Started on server0001...
Finished on server0001:
  {
    "status": "installed",
    "version": "4.14.3-26.el8"
  }
Successful on 1 target: server0001
Ran on 1 target in 8.35 sec

@mlemily mlemily requested a review from a team as a code owner June 19, 2023 14:42
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

@mlemily
Copy link
Contributor Author

mlemily commented Jun 19, 2023

Changed to just grep for the package name as that's infinitely more straight forward 🙂

@Ramesh7 Ramesh7 merged commit 79011b7 into puppetlabs:main Feb 28, 2024
19 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants