(MODULES-8045) Fix apt-get upgrading everything when no version passed and apt is package manager. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelSmith
suggested changes
Oct 3, 2018
davejohnston
changed the title
|
@MikaelSmith this PR was just raised to show someone an issue It is not a complete fix. I made a mistake with the issue number in the commit message and will address. |
eoinmcq
changed the title
eoinmcq
force-pushed
the
DI-3397/FixAptGetUpgrade
branch
3 times, most recently
from
f06074b
to
e17a073
Compare
eoinmcq
changed the title
|
@MikaelSmith I have raised a modules ticket and put more detail in with what the issue was. |
tphoney
reviewed
Oct 4, 2018
tasks/linux.sh
Outdated
| @@ -28,16 +28,19 @@ do | |||
| if [ "${version}" != "" ]; then | |||
| name="$name-$version" | |||
| fi | |||
| # upgrading to a specific version needs to use the install action | |||
eoinmcq
force-pushed
the
DI-3397/FixAptGetUpgrade
branch
from
e17a073
to
f8f843a
Compare
|
great work @eoinmcq 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://tickets.puppetlabs.com/browse/MODULES-8045
When using apt the current linux package updates all packages instead of the requested package when no version is specified. This is due to "upgrade" being used as the action. This will upgrade everything.
Solution
When updating a specific package using apt the 'install' argument should be used. This will update the package if it exists, or install it if it doesn't.
Testing