(maint) fixing up the fingerprint hexdigest in the initialize #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a valid hexidigest was getting expanded to have double colon which caused issues when comparing the fingerprint from the device. This PR will resolve that issue by trimming out the ':'s and then correctly creates the fingerprint
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
========================================
+ Coverage 99.91% 100% +0.08%
========================================
Files 40 40
Lines 1136 1136
========================================
+ Hits 1135 1136 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
da-ar
reviewed
Jul 22, 2019
da-ar
approved these changes
Jul 22, 2019
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a valid hexidigest was getting expanded to have double colon which caused issues when comparing the fingerprint from the device.
This PR will resolve that issue by trimming out the ':'s and then correctly creates the fingerprint