Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-999) - Removal of inappropriate terminology #123

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 10, 2020

The removal of any offensive or inappropriate terminology from the code base. Includes a backwards incompatible name change to a manifest.

@david22swan david22swan added the backwards-incompatible Breaking change label Nov 10, 2020
@puppet-community-rangefinder
Copy link

panos::install is a class

that may have no external impact to Forge modules.

panos::install::server is a class

that may have no external impact to Forge modules.

panos::server is a class

that may have no external impact to Forge modules.

This module is declared in 1 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #123 (0dbadbe) into main (25bd45e) will increase coverage by 15.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             main      #123       +/-   ##
============================================
+ Coverage   84.27%   100.00%   +15.72%     
============================================
  Files          40        40               
  Lines        1189      1136       -53     
============================================
+ Hits         1002      1136      +134     
+ Misses        187         0      -187     
Impacted Files Coverage Δ
lib/puppet/util/task_helper.rb 100.00% <0.00%> (+4.34%) ⬆️
lib/puppet/util/network_device/panos/device.rb 100.00% <0.00%> (+11.11%) ⬆️
lib/puppet_x/puppetlabs/panos/transport_shim.rb 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25bd45e...0dbadbe. Read the comment docs.

The removal of any offensive or inappropriate terminology from the code base. Includes a backwards incompatible name change to a manifest.
@david22swan david22swan force-pushed the IAC-999/main/removal_of_inappropriate_terminology branch from d98434e to b0ca5cf Compare November 10, 2020 09:49
The resource_api gem is now included within Puppet 6 by default
@david22swan
Copy link
Member Author

PR only backwards incompatible if released before Puppet 5 support is dropped

@Disha-maker Disha-maker merged commit 608e3ae into puppetlabs:main Dec 7, 2020
@david22swan david22swan deleted the IAC-999/main/removal_of_inappropriate_terminology branch December 7, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants