Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-7496) fix for running apply runs from a PE/PS installation #66

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

Thomas-Franklin
Copy link
Contributor

@Thomas-Franklin Thomas-Franklin commented Oct 19, 2018

If running on a puppetserver it will be unable to locate the base provider panos_provider, this commit uses require_relative which will allow it to work on a puppetserver.

If running on a puppetserver it will be unable to locate the base provider `panos_provider` and the base provider used for the static routes and path monitor, this commit uses `require_relative` which will allow it to work on a puppetserver.
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          36     36           
  Lines         831    808   -23     
=====================================
- Hits          831    808   -23
Impacted Files Coverage Δ
lib/puppet/provider/panos_path_monitor_base.rb 100% <100%> (ø) ⬆️
...ppet/provider/panos_nat_policy/panos_nat_policy.rb 100% <100%> (ø) ⬆️
...rovider/panos_service_group/panos_service_group.rb 100% <100%> (ø) ⬆️
.../provider/panos_static_route/panos_static_route.rb 100% <100%> (ø) ⬆️
...rovider/panos_address_group/panos_address_group.rb 100% <100%> (ø) ⬆️
...vider/panos_virtual_router/panos_virtual_router.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_service/panos_service.rb 100% <100%> (ø) ⬆️
...panos_ipv6_static_route/panos_ipv6_static_route.rb 100% <100%> (ø) ⬆️
lib/puppet/provider/panos_static_route_base.rb 100% <100%> (ø) ⬆️
...nos_arbitrary_commands/panos_arbitrary_commands.rb 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73296bb...7483953. Read the comment docs.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DavidS DavidS merged commit 408163a into puppetlabs:master Oct 19, 2018
@Thomas-Franklin Thomas-Franklin added bug bugfix Signify a bug fix labels Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Signify a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants